Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QueryInfo.subscriptions (dead code) #11267

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Remove QueryInfo.subscriptions (dead code) #11267

merged 4 commits into from
Oct 2, 2023

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Oct 2, 2023

I just noticed that while doing a code review - from what I can gather, this property is never referenced anywhere, so we can probably remove it.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 5f63e85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.06 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.41 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 41.96 KB (-0.04% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.49 KB (-0.04% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.25 KB (-0.04% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (0%)
import { useQuery } from "dist/react/index.js" 4.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.08 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.58 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.4 KB (0%)
import { useMutation } from "dist/react/index.js" 2.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.51 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.24 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.59 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.02 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.52 KB (0%)
import { useReadQuery } from "dist/react/index.js" 2.96 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.91 KB (0%)
import { useFragment } from "dist/react/index.js" 2.08 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.03 KB (0%)

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 06b5a31
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/651ae80f096dc400087a9992
😎 Deploy Preview https://deploy-preview-11267--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jerelmiller
jerelmiller approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@phryneas phryneas merged commit bc055e0 into main Oct 2, 2023
8 checks passed
@phryneas phryneas deleted the pr/dead-code-1 branch October 2, 2023 17:18
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phryneas @jerelmiller